geonetwork / core-geonetwork

GeoNetwork is a catalog application to manage spatially referenced resources. It provides powerful metadata editing and search functions as well as an interactive web map viewer. It is currently used in numerous Spatial Data Infrastructure initiatives across the world.
http://geonetwork-opensource.org/
GNU General Public License v2.0
403 stars 481 forks source link

Temporary RDF and MEF files are never deleted #4598

Open juanluisrp opened 4 years ago

juanluisrp commented 4 years ago

The RDF temporary files created here are never deleted causing a disk space leak:

https://github.com/geonetwork/core-geonetwork/blob/405d517d519acb6b8068f84fc137dbfc61456fa4/services/src/main/java/org/fao/geonet/api/records/rdf/RdfOutputManager.java#L116-L120

https://github.com/geonetwork/core-geonetwork/blob/405d517d519acb6b8068f84fc137dbfc61456fa4/services/src/main/java/org/fao/geonet/api/records/rdf/RdfOutputManager.java#L178

We need to manually remove these files after using them or if we can't use File.deleteOnExit() method to remove them when the JVM exits.

The same problem happens with temp MEF files: https://github.com/geonetwork/core-geonetwork/blob/405d517d519acb6b8068f84fc137dbfc61456fa4/core/src/main/java/org/fao/geonet/kernel/mef/MEFExporter.java#L115 https://github.com/geonetwork/core-geonetwork/blob/405d517d519acb6b8068f84fc137dbfc61456fa4/core/src/main/java/org/fao/geonet/kernel/mef/MEF2Exporter.java#L105

josegar74 commented 6 months ago

@juanluisrp can be closed this ticket?