search

geonetwork / core-geonetwork

GeoNetwork is a catalog application to manage spatially referenced resources. It provides powerful metadata editing and search functions as well as an interactive web map viewer. It is currently used in numerous Spatial Data Infrastructure initiatives across the world.
http://geonetwork-opensource.org/
GNU General Public License v2.0
412 stars 487 forks source link

Relevancy looses capital when selected #4678

Open pvgenuchten opened 4 years ago

pvgenuchten commented 4 years ago

in the sort by field in search the term relevancy is lower cased when selected, this does not happen for the other modes

image

fxprunayre commented 4 years ago

Relevancy is correct, no? It is fixed in v4.

MichelGabriel commented 4 years ago

It looks like it takes the name from the 'Field', and {field: 'relevancy'} is in small caps.

MichelGabriel commented 4 years ago

It is fixed in v4

@fxprunayre What is v4?

fxprunayre commented 4 years ago

@fxprunayre What is v4?

In branch 4.0.x, labels for sort options are lower case https://github.com/geonetwork/core-geonetwork/blob/4.0.x/web-ui/src/main/resources/catalog/locales/en-core.json#L201-L210 and capitalized in CSS when needed. Not sure it is the best practice in that case but it works and make sense.

Similar issue can occur when you've ":" which in some language are with a space before or not - so in general we should always store them in labels ? but sometimes we do, sometimes not...

MichelGabriel commented 4 years ago

Branch 4.0, of course. Thanks

MichelGabriel commented 4 years ago

This particular case happens in GeoNetwork 3.6, in gn_search.less: https://github.com/geonetwork/core-geonetwork/blob/c034f9996541c59551e67ef14a28b12de03126a9/web-ui/src/main/resources/catalog/style/gn_search.less#L188-L194