geonetwork / core-geonetwork

GeoNetwork is a catalog application to manage spatially referenced resources. It provides powerful metadata editing and search functions as well as an interactive web map viewer. It is currently used in numerous Spatial Data Infrastructure initiatives across the world.
http://geonetwork-opensource.org/
GNU General Public License v2.0
420 stars 489 forks source link

when importing thesaurus from inspire registry in german language, an inproper date is used #4726

Open pvgenuchten opened 4 years ago

pvgenuchten commented 4 years ago

i found inconsistent behaviour between importing spatial-scope codelist from inspire registry if you download it in english language or in german language.

for english language is created with the relevant date 2019-05-22, in german language is used the date of today

is this a problem in geonetwork or on inspire registry side

cc @fxprunayre @MarcoMinghini

df-git commented 4 years ago

Dear @pvgenuchten, The INSPIRE registry is providing a specific skos/rdf file for "Priority Dataset" and "Spatial Scope". This files, contains one date for all the languages.

pvgenuchten commented 4 years ago

Thank you @df-git, in the meanwhile i learned that geonetwork adds the relevant date hardcoded for certain thesauri, see https://github.com/geonetwork/core-geonetwork/blob/master/web/src/main/webapp/xslt/services/thesaurus/registry-to-skos.xsl#L77-L87. apparently this has a non expected behaviour when using german language only. Also priority dataset seems not included, i'm going to fix that. So in stead of using your prepared downloads, the software will add the relevant date. Still those prepared thesauri would be good to keep as a reference to the Metadata TG.

gannebamm commented 2 months ago

Hi, we encountered the same issue (years later). See the GEMET date in this metadata entry: https://gdi-catalog.bmel.de/srv/api/records/d01ee80b-0b9f-4a91-bde7-59e6f1849a00/formatters/xml

We do not know how to fix the thesaurus CI_Date info. If we try to edit the xml, it will not get saved properly. Here is the relevant part:

<gmd:descriptiveKeywords>
    <gmd:MD_Keywords>
        <gmd:keyword>
            <gco:CharacterString>Umweltüberwachung</gco:CharacterString>
        </gmd:keyword>
        <gmd:type>
            <gmd:MD_KeywordTypeCode codeList="http://standards.iso.org/iso/19139/resources/gmxCodelists.xml#MD_KeywordTypeCode" codeListValue="theme"/>
        </gmd:type>
        <gmd:thesaurusName>
            <gmd:CI_Citation>
                <gmd:title>
                    <gco:CharacterString>GEMET - INSPIRE themes, version 1.0</gco:CharacterString>
                </gmd:title>
                <gmd:date>
                    <gmd:CI_Date>
                        <gmd:date>
                            <gco:Date>2008-01-01</gco:Date> <!-- <<< THIS IS WRONG -->
                        </gmd:date>
                        <gmd:dateType>
                            <gmd:CI_DateTypeCode codeList="http://standards.iso.org/iso/19139/resources/gmxCodelists.xml#CI_DateTypeCode" codeListValue="publication"/>
                        </gmd:dateType>
                    </gmd:CI_Date>
                </gmd:date>
                <gmd:identifier>
                    <gmd:MD_Identifier>
                        <gmd:code>
                            <gmx:Anchor xlink:href="https://gdi-catalog.bmel.de/srv/api/registries/vocabularies/external.theme.httpinspireeceuropaeutheme-theme">
geonetwork.thesaurus.external.theme.httpinspireeceuropaeutheme-theme
                            </gmx:Anchor>
                        </gmd:code>
                    </gmd:MD_Identifier>
                </gmd:identifier>
            </gmd:CI_Citation>
        </gmd:thesaurusName>
    </gmd:MD_Keywords>
</gmd:descriptiveKeywords>

The service runs on GeoNetwork 3.12.11.0

fxprunayre commented 2 months ago

The INSPIRE registry does not provide this date on export, so GeoNetwork set it based on https://github.com/geonetwork/core-geonetwork/blob/main/web/src/main/webapp/xslt/services/thesaurus/registry-to-skos.xsl#L77-L93.

One option if this is not available in your version is to download the thesaurus, update the date in the SKOS file, delete thesaurus and upload it manually.