dirty style in batch-privileges usefull?

pvgenuchten commented 3 years ago

https://github.com/geonetwork/core-geonetwork/blob/b89be7ca00f45e9caabbf027479f654f5ed628a7/web-ui/src/main/resources/catalog/style/gn.less#L843 introduces a star next to a checkbox in bulk-privilege updates, the behaviour is a bit awkward, because dirty is not removed if you cancel the checkbox, also the star-style is not very clear that it relates to the element being dirty. dirty is more interesting on the individual privileges panel, in case the panel is pre loaded from database.

suggestion would be to remove the dirty-style or make it less intrusive (for example a yellow colored border around the checkbox)

fxprunayre commented 3 years ago

untouched means nothing will change
the star flag that you're going to remove that privileges.
checked means you add

BTW same should be added to category panel in order to be able to delete category.

ianwallen commented 3 years ago

This issue is also related to https://github.com/geonetwork/core-geonetwork/issues/4804

pvgenuchten commented 3 years ago

the star flag that you're going to remove that privileges.

this needs some review, because currently doesn't work like that. as you describe it, does this make sense in bulk mode? seems only relevant to single-mode?

fxprunayre commented 3 years ago

because currently doesn't work like that

Did a quick test on https://vanilla.geocat.net/geonetwork/srv/fre/catalog.search#/metadata/da165110-88fd-11da-a88f-000d939bc5d8 and works as expected. eg. remove only privileges to internet group:

does this make sense in bulk mode?

Yes if you want to remove privileges for a group preserving existing one for others.

MichelGabriel commented 3 years ago

For me the * symbol is not so clear. This symbol usually means that something is a required field.

Is it also a required field in this case?

ianwallen commented 3 years ago

For bulk changes it does work as I would expected but I find the terminology a little confusing.

Did test on https://vanilla.geocat.net/geonetwork/

Created 2 new records with title starting with PRIVTEST

Set permissions to the following for both records.

Next I did a search for PRIVTEST, selected the 2 records and selected "update privileges"

Then I selected the following.

and clicked on "add selected"

Both records now look like this.

Which, I believe is what was expected.

Issues

For publishing Intranet - once I selected the option - I could not unselect it. The star would not get removed. The only option was to close the window and start again. I think the 3 state selection box that Paul is suggesting would make this much better.
I believe the button called "add selected" is a little confusing. For "publishing Intranet" - I was removing the selection. I don't have any better words to use at the moment but I'm sure better wording could be used.
The help goes to the docs which seems old as none of the screen shots look close to the functionality so there was not explanation of how this is expected to work.

fxprunayre commented 3 years ago

I believe the button called "add selected" is a little confusing. For "publishing Intranet" - I was removing the selection. I don't have any better words to use at the moment but I'm sure better wording could be used.

Maybe append or merge with selected?

BTW same should be added to category panel in order to be able to delete category.

Adding support for category removal on a selection in https://github.com/geonetwork/core-geonetwork/pull/5222

geonetwork / core-geonetwork

dirty style in batch-privileges usefull? #5211