geonetwork / core-geonetwork

GeoNetwork is a catalog application to manage spatially referenced resources. It provides powerful metadata editing and search functions as well as an interactive web map viewer. It is currently used in numerous Spatial Data Infrastructure initiatives across the world.
http://geonetwork-opensource.org/
GNU General Public License v2.0
412 stars 487 forks source link

Microdata embeddings in wrong format #6562

Open ottowg opened 1 year ago

ottowg commented 1 year ago

Embedded Microformat is incorrect predicates of schema.org annotations is not formatted the right way.

Consequence: SEO is not working properly

Example: name of Dataset (same holds for other predicates) (https://gdk.gdi-de.org/geonetwork/srv/api/records/de.dwd.mosmix.71816) How it is:

            <div class="row">
              <div class="col-md-8">
                <header>
                  <h1 itemprop="name" itemscope="itemscope" itemtype="http://schema.org/name">
                    <i class="fa gn-icon-dataset">&nbsp;</i>
                    Model Output Statistics for GOOSE BAY (71816)
                  </h1>

Wrong: name should not be instanciated this is the Porperty! In general: If you use an itemtype with lowecase beginning, something seems to be wrong. (itemtype="http://schema.org/Dataset" vs. itemtype="https://schema.org/name"

How it should be:

            <div class="row">
              <div class="col-md-8">
                <header>
                  <h1 itemprop="name">
                    <i class="fa gn-icon-dataset">&nbsp;</i>
                    Model Output Statistics for GOOSE BAY (71816)
                  </h1>
fxprunayre commented 1 year ago

Since 3.8, microdata were removed (https://github.com/geonetwork/core-geonetwork/pull/3903) in favor of JSON-LD (https://github.com/geonetwork/core-geonetwork/pull/3714).

ottowg commented 1 year ago

Thank you for your info. Than https://gdk.gdi-de.org/geonetwork/srv/api/records/de.dwd.mosmix.71816 seems not on the last version and this issue is not for this repo, but for gdk.gdi-de.org.

ThomasJunk commented 1 year ago

@ottowg It looks like this issue is closable?