Accessibility issue: Single character key shortcuts

geonetwork / core-geonetwork

GeoNetwork is a catalog application to manage spatially referenced resources. It provides powerful metadata editing and search functions as well as an interactive web map viewer. It is currently used in numerous Spatial Data Infrastructure initiatives across the world.

http://geonetwork-opensource.org/

GNU General Public License v2.0

412 stars 487 forks source link

Accessibility issue: Single character key shortcuts #8002

Open alexarobu opened 4 months ago

alexarobu commented 4 months ago

Describe the bug A clear and concise description of what the bug is.

According to a recent accessibility test we've got the following issue reported back to us:

It is expected that if single-character keyboard shortcuts are present, then at least one of the following is true:

Turn-off – A mechanism is available to turn the shortcut off
Remap - A mechanism is available to remap the shortcut to include one or more non-printable keyboard keys (e.g., Ctrl, Alt)
Active only on focus - The keyboard shortcut for a user interface component is only active when that component has focus.

Additional context Any help to get any of the suggested fixes in place would be greatly appreciated :pray:

fxprunayre commented 4 months ago

Turn-off – A mechanism is available to turn the shortcut off

I'm not sure if it is good enough, but https://github.com/geonetwork/core-geonetwork/pull/6516 will add a setting to turn hot keys off (see changes)

alexarobu commented 4 months ago

Hi @fxprunayre

Thank you for your response!! :smile:

I can't tell by looking at the discussion on the PR how will one turn the hotkeys off, will you be able to point me in the right direction? Will it be in the settings or what will the actual mechanism be? Sorry if I'm missing something really obvious!

Many many thanks!

fxprunayre commented 4 months ago

Sure, it will be in the UI configuration here https://github.com/geonetwork/core-geonetwork/blob/42-webcomponents/web-ui/src/main/resources/catalog/js/CatController.js#L72

alexarobu commented 4 months ago

@fxprunayre thank you so much for the clarification :pray: so that will basically get included in the Admin Console > Settings > UI Settings, won't it?

fxprunayre commented 4 months ago

so that will basically get included in the Admin Console > Settings > UI Settings, won't it?

yes

alexarobu commented 4 months ago

@fxprunayre sorry to be a pain, just one more question: if our client decides that this is not enough, do you think I could easily surface this option into some sort of button or whatever to the general public rather than the Admins? :see_no_evil: