Open tobias-hotz opened 3 weeks ago
@tobias-hotz the pull request looks good to me, but would be good to have a list of tests failing in Windows due to the line endings to update the code to use the current system line ending.
Can we just fix the tests please rather than require Linux line feeds? windows is a supported environment is it not? We may as well test for it …
If it helps we can setup a windows GitHub workflow to keep the tests passing correctly …
Thanks for your feedback. I've taken a look at the errors more closely, and it turns out there are more errors than just line endings. I've fixed all test failures in the lastest commit, so all unit tests now pass on windows. Please note that this also required some adjustment to non-test classes, as there were some errors/assumptions in wro4j regarding windows handling. Please read the commit message for more details. With these changes, all tests now pass on windows and linux.
I've also notices that MessageProducerTest sometimes fails. It seems like the test is not written thread-safe. I've fixed this test in the lastest commit to make it thread-safe
Currently, when setting up the project as described on windows, you cannot run unit tests locally, as they assume LF line endings at various places. Using the WSL on Windows means that these unit tests can be run. Due to IntelliJ's good integration into the WSL, this works very seamless with IntelliJ as well.
Also include some minor fixes like incorrect links and outdated documentation
Checklist
main
branch, backports managed with labelREADME.md
filespom.xml
dependency management. Update build documentation with intended library use and library tutorials or documentationFunded by LGL BW