geonetwork / core-geonetwork

GeoNetwork is a catalog application to manage spatially referenced resources. It provides powerful metadata editing and search functions as well as an interactive web map viewer. It is currently used in numerous Spatial Data Infrastructure initiatives across the world.
http://geonetwork-opensource.org/
GNU General Public License v2.0
430 stars 489 forks source link

Thesaurus / Date improvements. #8392

Closed fxprunayre closed 1 month ago

fxprunayre commented 1 month ago

https://github.com/geonetwork/core-geonetwork/pull/6972/files#diff-c7548d94bdb4268915f50f66df5a90f1f7868e4fb1de2f3d2938397e202aaf2fR1057 added month and year format support. This was resolving thesaurus date to the last matching format ie. 1st January for the default date.

This can be tested using regions thesaurus which will contains 2 dates for the thesaurus block.

https://github.com/geonetwork/core-geonetwork/pull/6972 adds retrieval of dct:issued|modified|created dates but multiple dates could be added more than one time with same date type code. Improve the mapping (and add more flexibility to customize date type code).

@wangf1122, @ianwallen if you could review to check if the grouping of various dates match your requirements?

Misc:

Checklist

Funded by Service Public de Wallonie

fxprunayre commented 1 month ago

Also I'm not sure what we should do if a thesaurus has no date defined?

wangf1122 commented 1 month ago

@fxprunayre

I have cherry picked your commit to our system with HNAP schema. No impact. and looking good.

fxprunayre commented 1 month ago

I have cherry picked your commit to our system with HNAP schema. No impact. and looking good.

Thanks for the review @wangf1122 . For INSPIRE validation, only one date is set for the thesaurus when imported from registry to only set publication date in records. I updated the import transformations for that case.

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud