geonetwork / core-geonetwork

GeoNetwork is a catalog application to manage spatially referenced resources. It provides powerful metadata editing and search functions as well as an interactive web map viewer. It is currently used in numerous Spatial Data Infrastructure initiatives across the world.

http://geonetwork-opensource.org/

GNU General Public License v2.0

430 stars 489 forks source link

Unable to rename graphicOverview #8442

Open tylerjmchugh opened 1 month ago

tylerjmchugh commented 1 month ago

This PR arose from the HNAP PR 403 where the graphic overviews could not be updated with a new name. It was suggested that iso19139 could also use these changes. I am unable to test this however as there does not appear to be an edit option for graphic overviews on iso19139 like there is on HNAP.

Checklist

[X] I have read the contribution guidelines
[X] Pull request provided for main branch, backports managed with label
[ ] Good housekeeping of code, cleaning up comments, tests, and documentation
[X] Clean commit history broken into understandable chucks, avoiding big commits with hundreds of files, cautious of reformatting and whitespace changes
[X] Clean commit messages, longer verbose messages are encouraged
[ ] API Changes are identified in commit messages
[ ] Testing provided for features or enhancements using automatic tests
[ ] User documentation provided for new features or enhancements in manual
[ ] Build documentation provided for development instructions in README.md files
[ ] Library management using pom.xml dependency management. Update build documentation with intended library use and library tutorials or documentation

josegar74 commented 1 month ago

With iso19139 in main branch to get the edit button in the thumbnails is required to use in the sidePanel element:

 <directive data-gn-onlinesrc-list=""/>

    <view name="default" default="true"
          class="gn-label-above-input gn-indent-bluescale">
      <sidePanel>
          <directive data-gn-onlinesrc-list=""/>
...

I can not reproduce the issue in main, where I could update the resource name properly.

Pending to verify it 4.2.x branch.

tylerjmchugh commented 1 month ago

With iso19139 in main branch to get the edit button in the thumbnails is required to use in the sidePanel element:
 <directive data-gn-onlinesrc-list=""/>
    <view name="default" default="true"
          class="gn-label-above-input gn-indent-bluescale">
      <sidePanel>
          <directive data-gn-onlinesrc-list=""/>
...
I can not reproduce the issue in main, where I could update the resource name properly.

Pending to verify it 4.2.x branch.

@josegar74 Tested on 4.2.x and I cannot reproduce there either. The file name seems to be updated correctly.

So this PR is not required then?

ianwallen commented 1 month ago

@josegar74, @tylerjmchugh If the changes work with or without these changes I suggest to still apply the changes because

it is the same logic as HNAP so it would avoid confusion.
it uses similar logic to onlinesrc-add.xsl so it would avoid confusion.

So by applying the changes, it would make the code more consistent.

tylerjmchugh commented 1 month ago

@josegar74, @tylerjmchugh If the changes work with or without these changes I suggest to still apply the changes because

it is the same logic as HNAP so it would avoid confusion.

it uses similar logic to onlinesrc-add.xsl so it would avoid confusion.

So by applying the changes, it would make the code more consistent.

Tested and confirmed that resources can be renamed with and without the changes on main and 4.2.x. Applying the changes anyways should not cause issues.