formatters configuration, being able to ouput data as if they were served by a legacy gn4 or as if they were served by the gn microservices

geonetwork / geonetwork-microservices

GNU General Public License v2.0

13 stars 18 forks source link

formatters configuration, being able to ouput data as if they were served by a legacy gn4 or as if they were served by the gn microservices #47

Closed cmangeat closed 2 years ago

cmangeat commented 3 years ago

Adding a withoutSQL spring profile, in case of standalone / no SQL db deployment, when no links to the db are needed
Introducing a FormatterConfiguration objects hierarchy to be able to customize the output (baseURL for records, site name, ...)
Cleaning up useless imports
Transforming static methods calls into calls onto beans (dcatConverter)
Adding a @Qualifier annotation so that we make sure to wire the expected bean
Several tests have been added to the testsuite.

cmangeat commented 3 years ago

@pmauduit, had to

os.toString(UTF_8).replace("<?xml version=\"1.0\" encoding=\"UTF-8\"?>", "");

in order the test to fail the right way !

(will maybe also have to re-configure my identation policy)

pmauduit commented 3 years ago

Maybe we'd need something like instead (ignoring prolog) ? https://github.com/xmlunit/xmlunit/issues/59#issuecomment-198755192

cmangeat commented 3 years ago

Also, I didn't get why the search_without_sql gets rid of the Xslt / Xml responseProcessorImpl java classes, as I cannot see the link between the name of the classes and a database, but I'm probably missing some context here.

So to avoid "Field metadataRepository in org.fao.geonet.common.search.processor.impl.XmlResponseProcessorImpl required a bean of type 'org.fao.geonet.repository.MetadataRepository' that could not be found." as had to exclude common-persistence (https://github.com/geonetwork/geonetwork-microservices/pull/47/files#diff-6fcf1652a05da8efe4df9caa14d18e72256d7413bcb1b936583d3ab99f11075dR41) so not get database autoconfiguration attempt (there are maybe cleaner ways to avoid it).

pmauduit commented 3 years ago

looks good to me then, thanks for the clarifications

cmangeat commented 3 years ago

@josegar74 or @fxprunayre can you please have a look ?

fvanderbiest commented 2 years ago

Up for a review ? Thanks

fvanderbiest commented 2 years ago

We've been waiting for more than 25 days with no review. How can we help ?