search

geonetwork / geonetwork-microservices

GNU General Public License v2.0
13 stars 18 forks source link

Build / Fix issue with JDK16+ #71

Closed fxprunayre closed 1 year ago

fxprunayre commented 1 year ago

See https://stackoverflow.com/questions/65380359/lomboks-access-to-jdk-compilers-internal-packages-incompatible-with-java-16

Investigation made and problem solved with @GeryNi

fgravin commented 1 year ago

It means that the project builds with java 16 ? Might be good to mention a range of supported Java versions in the README, what do you think ? Thanks

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

fxprunayre commented 1 year ago

It means that the project builds with java 16 ?

The project should build fine with any JDK11+ but we encountered some compilation failure with a JDK16 yesterday not related to the project in itself.

Might be good to mention a range of supported Java versions in the README, what do you think ?

It looks quite clear that the app need JDK11+ to build and JRE11+ to run https://github.com/geonetwork/geonetwork-microservices/blob/main/pom.xml#L50 and https://github.com/geonetwork/geonetwork-microservices#requirements

fgravin commented 1 year ago

Well I don't really work with Java those days but when I read Java 11 it's Java 11, not Java 11+. Maybe just adding the + would make things clearer for people like me :relaxed: