search

geopandas / contextily

Context geo-tiles in Python
https://contextily.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
520 stars 82 forks source link

CI failing #200

Closed martinfleis closed 1 year ago

martinfleis commented 2 years ago

Since the last week, our CI is failing. test_place seems to return unexpected values, causing its tests and add_basemap tests to fail.

darribas commented 2 years ago

We need to check this is an actual fail or a (minor) update of the underlying imagery that we use for testing that is making the specific tests fail. The latter has happened in the past and we have resorted to 1) ensuring the code still does what it's meant to 2) update the tests so they pass with the current imagery.

EwoutH commented 1 year ago

They all fail with the same error:

E       ValueError: The specified zoom level of 20 is not valid for the current tile provider (valid zooms: 0 - 18).

Since the CI is also tested on a schedule and did suddenly fail without any code changes on our side, it must be an environment change. I suspect a dependency updated their default (base)map, which only has other zoom levels and only supports zoomlevels up to 18.

Or (imo less likely), the zoomlevels for the (base)map we're using got updated and range now at most to 18.

The CI passed on 2022-07-14, and failed from 2022-07-21.

Could it be an update in xyzservices? They didn't release any update in that period however. Any other suspicions?

martinfleis commented 1 year ago

One failure is caused by a recent xyzservices update and other by some change in the output of geocoding or tiles served by Stamen. Will update the tests accordingly.