search

geopandas / contextily

Context geo-tiles in Python
https://contextily.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
517 stars 82 forks source link

os.wait fails in tile.py #244

Closed cragm closed 2 weeks ago

cragm commented 1 month ago

I expect os.wait(wait) at line 447 in tile.py will always fail.

In Windows, I expect something like:

AttributeError: module 'os' has no attribute 'wait'

In Linux (and presumably MacOS), I expect something like:

TypeError: posix.wait() takes no arguments (1 given)

This seems to be consistent with the standard library documentation https://docs.python.org/3/library/os.html#os.wait

Given the context, I assume time.sleep(wait) would provide something closer to the intended outcome. https://docs.python.org/3/library/time.html#time.sleep

Apologies, if I'm missing something. I'd been using Contextily for a while and only noticed this problem when some internet gremlin happened to lead to the invocation of line 447. Thanks!

martinfleis commented 1 month ago

Good catch! This is nearly impossible to test. Will push a fix.