geopandas / dask-geopandas

Parallel GeoPandas with Dask
https://dask-geopandas.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
486 stars 45 forks source link

TST: use fixtures for accessing geopandas datasets #266

Closed jorisvandenbossche closed 6 months ago

jorisvandenbossche commented 6 months ago

This is a (potentially temporary) solution for the geopandas datasets being deprecated / removed.

All usages have been updated to use a fixture, so we have a centralized place where the path is defined. And for now, just let that path be the old geopandas.datasets one, or the new path to the test data included in geopandas for newer versions. Longer term, we probably ideally wouldn't rely on such internal test data of geopandas, but that's something we can clean up later.

martinfleis commented 6 months ago

This will not work. We no longer ship the data with the package, so it is not available in installed geopandas.

jorisvandenbossche commented 6 months ago

Yeah, I figured that in the meantime .. It's only the dev build here, though, and makes that I can at least already run the tests locally (with a geopandas dev build)

What do we prefer? Include the data here as well on the short term? Longer term try to replace the cities/lowres with a simple generated points and polygons dataset?

martinfleis commented 6 months ago

We can temporarily include them here. Then I'd switch to some real-world data from geodatasets.