Raise error if function is used with parameters to read no geometry, columns, or fids - Githubissues

geopandas / pyogrio

Vectorized vector I/O using OGR

https://pyogrio.readthedocs.io

MIT License

260 stars 22 forks source link

Raise error if function is used with parameters to read no geometry, columns, or fids #280

Closed theroggy closed 10 months ago

theroggy commented 10 months ago

Necessary changes and tests to ensure following behaviour for both use_arrow=True and use_arrow=False:

if columns=[], read_geometry=False and return_fid/fid_as_index=False, a ValueError is raised
if columns=[], read_geometry=False and return_fid/fid_as_index=True, the index is read and returned
if none of the above, but fid_as_index=False and the result ends up having no geometry nor attribute columns (eg. because the input file doesn't have a geometry column and columns=[]), an empty DataFrame is returned.

closes #263

theroggy commented 10 months ago

@brendan-ward I resolved your suggestions.