This sidesteps making a decision around implementing support for negative skip_features in #309 for now and simply disallows that, which would have been equivalent to the behavior prior to #282. We can add support for negative slicing at a different time, if we so choose.
This raises a specific ValueError and expands tests to match. I also added checks for negative max_features and associated tests.
This sidesteps making a decision around implementing support for negative
skip_featuresin #309 for now and simply disallows that, which would have been equivalent to the behavior prior to #282. We can add support for negative slicing at a different time, if we so choose.This raises a specific
ValueErrorand expands tests to match. I also added checks for negativemax_featuresand associated tests.