search

geopandas / pyogrio

Vectorized vector I/O using OGR
https://pyogrio.readthedocs.io
MIT License
259 stars 22 forks source link

Avoid usage of packaging in non-test code #318

Closed jorisvandenbossche closed 8 months ago

jorisvandenbossche commented 8 months ago

See https://github.com/geopandas/pyogrio/issues/316#issuecomment-1780574589, this avoids adding it as an actual dependency.

jorisvandenbossche commented 8 months ago

Sorry, this is really stupid. I just went from the error I saw on the conda-forge build, and didn't do a proper search for the usage of packaging, and we are also still using it in _compat.py ... and so 0.7.1 didn't fix the issue.

I suppose we then just add packaging to the dependencies?

martinfleis commented 8 months ago

I suppose we then just add packaging to the dependencies?

That is probably the best option. We can revert this PR and add packaging as dependency here and then in meta on conda-forge.

brendan-ward commented 8 months ago

Sorry, this is my fault for adding it to verify shapely / pandas versions; easy to overlook because our dev / test environments already have it.

I'll try to get a fix in place a bit later today.