jorisvandenbossche
commented
5 months ago It's always "fingers crossed" when updating the wheel building, but it seems that this worked from the first try! ;)
Closed jorisvandenbossche closed 5 months ago
jorisvandenbossche
commented
5 months ago It's always "fingers crossed" when updating the wheel building, but it seems that this worked from the first try! ;)
brendan-ward
commented
5 months ago Thanks for working on this @jorisvandenbossche !
What do you think about making this a new minor version instead of a patch release? (meaning: 0.8.0 instead of 0.7.3) I think in general we've tried to make a minor version upgrade of GDAL in the wheels a minor version upgrade on our end.
In terms of order of operations, would it be better to get #323 in place for the updated actions, or get this PR out before merging that?
jorisvandenbossche
commented
5 months ago Yes, I was thinking the same. I was planning to open an issue, but then thought to just discuss this in the geopandas meeting. I was also thinking doing a 0.8.0 because generally we shouldn't bump GDAL (except for bug fixes) in a bug-fix release. We only don't really have other "features" to release for 0.8.0 apart from a new GDAL version, though. But maybe that doesn't really matter :shrug:
I don't think it matters which PR goes first (and there shouldn't be much conflicts), so feel free to merge yours first.
And it seems windows is still occasionally crashing at clean up
Closes https://github.com/geopandas/pyogrio/issues/340
Like https://github.com/geopandas/pyogrio/pull/298, now updating to GDAL 3.8.3 (https://github.com/microsoft/vcpkg/commit/6df4d4f49866212aa00fcd85fde5356503dafed1)