geopandas / pyogrio

Vectorized vector I/O using OGR
https://pyogrio.readthedocs.io
MIT License
258 stars 22 forks source link

BLD/RLS: fix aarch64 wheel building #352

Closed jorisvandenbossche closed 4 months ago

jorisvandenbossche commented 5 months ago

Seems to be a similar failures as https://github.com/microsoft/vcpkg/issues/36094

jorisvandenbossche commented 4 months ago

With the patch applied, the wheel building now succeeds.

But, now there is another error when running the tests on Circle CI itself (https://app.circleci.com/pipelines/github/geopandas/pyogrio/212/workflows/286ba63b-997f-4bfa-8784-626c1a10886e/jobs/105):

GDAL version: (3, 8, 3)
GEOS version: (3, 11, 3)
============================= test session starts ==============================
platform linux -- Python 3.10.3, pytest-8.0.0, pluggy-1.4.0 -- /opt/circleci/.pyenv/versions/3.10.3/bin/python3
cachedir: .pytest_cache
rootdir: /home/circleci
collected 0 items / 1 error                                                    

==================================== ERRORS ====================================
________________________ ERROR collecting test session _________________________
/opt/circleci/.pyenv/versions/3.10.3/lib/python3.10/site-packages/pluggy/_hooks.py:501: in __call__
    return self._hookexec(self.name, self._hookimpls.copy(), kwargs, firstresult)
/opt/circleci/.pyenv/versions/3.10.3/lib/python3.10/site-packages/pluggy/_manager.py:119: in _hookexec
    return self._inner_hookexec(hook_name, methods, kwargs, firstresult)
/opt/circleci/.pyenv/versions/3.10.3/lib/python3.10/site-packages/_pytest/main.py:403: in pytest_ignore_collect
    if not allow_in_venv and _in_venv(collection_path):
/opt/circleci/.pyenv/versions/3.10.3/lib/python3.10/site-packages/_pytest/main.py:376: in _in_venv
    return any(fname.name in activates for fname in bindir.iterdir())
/opt/circleci/.pyenv/versions/3.10.3/lib/python3.10/site-packages/_pytest/main.py:376: in <genexpr>
    return any(fname.name in activates for fname in bindir.iterdir())
/opt/circleci/.pyenv/versions/3.10.3/lib/python3.10/pathlib.py:1015: in iterdir
    for name in self._accessor.listdir(self):
E   PermissionError: [Errno 13] Permission denied: '/opt/containerd/bin'
=========================== short test summary info ============================
ERROR ::opt - PermissionError: [Errno 13] Permission denied: '/opt/containerd/bin'
=============================== 1 error in 0.52s ===============================
ERROR: found no collectors for /opt/circleci/.pyenv/versions/3.10.3/lib/python3.10/site-packages/pyogrio/tests

Nothing should be changed here, so not fully sure why this is now failing ..

jorisvandenbossche commented 4 months ago

Keeping pytest<8 (the one thing I noticed was different with the last succeeding build on main) seems to have fixed it .. (potentially related https://github.com/pytest-dev/pytest/issues/9089, https://github.com/pytest-dev/pytest/issues/11781). EDIT: probably rather https://github.com/pytest-dev/pytest/issues/11904

jorisvandenbossche commented 4 months ago

The Windows failure should be fixed by upgrading cibuildwheel in https://github.com/geopandas/pyogrio/pull/359

jorisvandenbossche commented 4 months ago

Going to merge this as the aarch64 wheel building is passing now

brendan-ward commented 4 months ago

Thanks @jorisvandenbossche !