search

geopandas / pyogrio

Vectorized vector I/O using OGR
https://pyogrio.readthedocs.io
MIT License
258 stars 22 forks source link

BLD/RLS: to include spatialite in wheels or not to? #378

Open theroggy opened 3 months ago

theroggy commented 3 months ago

As mentioned here, https://github.com/geopandas/geopandas/pull/3223, think through whether it it would be better to include it or not...

jorisvandenbossche commented 1 month ago

Moving my comment from https://github.com/geopandas/pyogrio/issues/330#issuecomment-2028208074 here:

At this point the wheel build still doesn't include libspatialite support, i.e. the libspatialite feature is not enabled in the vcpkg GDAL build.

Looking at it again, it seems we could do that . @brendan-ward you commented about that in https://github.com/geopandas/pyogrio/issues/86#issuecomment-1109012589:

Not sure if this matters, but noting for the record that our vcpkg build does not include libspatialite (we don't enable that as an add-on feature); it is LGPL licensed, which likely has license implications for the wheels we create. I believe Fiona also does not build against libspatialite.

In https://github.com/geopandas/pyogrio/pull/161 I first added libspatialite feature, but then removed it again before the PR was merged, and I don't directly see any discussion or explanation that explains why I did that .. But there is a bit of discussion later at https://github.com/geopandas/pyogrio/pull/161#issuecomment-1269044332, which again mentions that fiona also doesn't have this.

Now, I don't think licensing is a problem, given that GEOS also uses LGPL, and we do already include that in the wheels.

Given that vcpkg has the feature to build GDAL with libspatialite, we should probably just try that.