search

geopandas / pyogrio

Vectorized vector I/O using OGR
https://pyogrio.readthedocs.io
MIT License
257 stars 21 forks source link

BUG: encoding not handled properly for wheels #398

Closed brendan-ward closed 2 months ago

brendan-ward commented 2 months ago

See failing tests: https://github.com/geopandas/pyogrio/actions/runs/8848749467/job/24299655017

Fails on Ubuntu / MacOS when creating non-UTF-8 encoded shapefiles. Fewer failures on Python 3.12 than previous versions.

First guess is that there is variation in the underlying libraries GDAL uses to convert from UTF-8 to an alternative encoding (libiconv?) under VCPKG than in our other CI environments.

jorisvandenbossche commented 2 months ago

I noted in https://github.com/geopandas/pyogrio/pull/161 that iconv is no longer included, but that can be enabled separately as an extra feature in the vcpkg install of GDAL. That's probably something to try

jorisvandenbossche commented 2 months ago

Ah, and you already just opened a PR doing exactly that ;)