TST: skip multisurface test with arrow to avoid crash

geopandas / pyogrio

Vectorized vector I/O using OGR

https://pyogrio.readthedocs.io

MIT License

276 stars 24 forks source link

TST: skip multisurface test with arrow to avoid crash #479

Closed theroggy closed 2 months ago

theroggy commented 2 months ago

I wonder if there is any use in delaying the release for this. It will have to be solved upstream... and pyogrio 0.9 with GEOS 3.13 has the same problem...

So, just skipping the test might be OK for now?

Reference: https://github.com/geopandas/pyogrio/issues/478

brendan-ward commented 2 months ago

Thanks for working on this @theroggy . I'm thinking we need a deeper fix here than skipping the tests, since occasionally users do try to work with nonlinear types and we are trying to make use of the Arrow interface more common.

I'm thinking we might be able to use OGRSetNonLinearGeometriesEnabledFlag when reading using Arrow to have a similar effect as what we are already doing when not using Arrow, and then we sidestep the issue in Shapely. Let me try a PR with that.

brendan-ward commented 2 months ago

Nevermind, OGRSetNonLinearGeometriesEnabledFlag has no effect when reading from GDAL using Arrow, likely by design.