search

geopandas / scipy2018-geospatial-data

BSD 3-Clause "New" or "Revised" License
334 stars 193 forks source link

Fixing path changes, case issues, and missing berlin data #4

Closed sjsrey closed 6 years ago

sjsrey commented 6 years ago

Note that some of the links at natural earth evidently have moved. Also a number of the attributes have had their case changed.

jorisvandenbossche commented 6 years ago

Can you do a "Kernel ->Restart & Clear Output" on the notebooks 1-4? Because now the diff is a bit difficult to see

sjsrey commented 6 years ago

Closing as needs fixing

sjsrey commented 6 years ago

will do on the "Kernel ->Restart & Clear Output" on the notebooks 1-4?"

sjsrey commented 6 years ago

Notebooks are fine, the only real changes that have to made for things to run on my end are:

https://github.com/geopandas/scipy2018-geospatial-data/pull/4/commits/8752c926051a8ebd938efe4d91f53fd3f84bb521

and

https://github.com/geopandas/scipy2018-geospatial-data/pull/4/commits/c679b4e307f66dd64fadf10d3404adca32570757#diff-b7cb75ca59993a879e29bed8cd8469b8

jorisvandenbossche commented 6 years ago

There is already a berlin-neighbourhoods.geojson, the shapefile you added is something different?

sjsrey commented 6 years ago

Notebook 06 uses the shp file.

We could rewrite that to use the geojson file. If so we should assign either Levi or me for the rewrite.

Actually, we need the shapefile as the geojson has missing values for a few locations that were "fixed" in constructing the shapefile (for the Basel presentation).

ljwolf commented 6 years ago

Let's just update the geojson with the median_price field and drop the two disconnected polys. We're not running the weights notebook, and I don't think it makes sense to build the shp then.

I can do this right now.

ljwolf commented 6 years ago

I've added my changes to @sjsrey, but my matplotlib rc is nonstandard, so coloring on some plots looks different.

ljwolf commented 6 years ago

OK, plots should look like standard mpl. sorry about that.

ljwolf commented 6 years ago

If you'd like, @sjsrey, git pull --rebase your sjr-add-gds-content branch and rerun 06,07,08 if you'd like to confirm the swap to a fixed & clean berlin-neighbourhoods.geojson has worked.