search

geopandas / xyzservices

Source of XYZ tiles providers
https://xyzservices.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
169 stars 32 forks source link

Ipyleaflet providers and fix for compress providers #83

Closed sackh closed 3 years ago

sackh commented 3 years ago

I have added some providers which were missing here and present in ipyleaflet Also while adding provider found an issue in provider_sources/_compress_providers.py If Group is already present and if we add new basemaps to the same group then it is overriding the dictionary due to line https://github.com/geopandas/xyzservices/blob/1f6ac89f4aaf7ab04ab40f5c659c32f100b8c3c6/provider_sources/_compress_providers.py#L52

example: OpenStreetMap group is already present, If I add a new entry in this group then as per existing code it will replace the value and will keep only the new value, it is not updating the dictionary. Please correct me if I am wrong. I have also created PR # https://github.com/jupyter-widgets/ipyleaflet/pull/857 in ipyleaflet to support xyzservices.

martinfleis commented 3 years ago

@sackh Thanks! I have moved the added metadata to provider_sources/xyzservices-providers.json so they are not lost after make compress and reverted the suggested change in the compress script because it was obviously a wrong suggestion from my side. Also added a changelog.