search

geopandas / xyzservices

Source of XYZ tiles providers
https://xyzservices.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
169 stars 32 forks source link

TST: test more providers requiring API keys #87

Closed martinfleis closed 3 years ago

martinfleis commented 3 years ago

With this PR, all our providers are tested with two exceptions: HERE and AzureMaps.

HERE contains legacy authentication requiring app_id and app_code which is not possible to obtain anymore. It has been replaced by HEREv3 with apiKey. That one is tested.

AzureMaps have a free tier limited to 5000 requests in total, not per month. If I created a token on my account as I did with other services, it would eventually overflow and charged me. Hence not tested at the moment.

jorisvandenbossche commented 3 years ago

Might be worth adding some dev docs (comment in the workflow file?) about how those are tested (you created free personal accounts for each of those services and included a token as secrets?)

martinfleis commented 3 years ago

I have added a comment to the test file https://github.com/geopandas/xyzservices/blob/1886db962af2315027fe270143c48dff20eb2615/tests/test_providers.py#L89-L91 But it is true that it can be expanded. Yeah, I've created my personal tokens for this.