geopaparazzi / GSS

2 stars 5 forks source link

Build Docker image #19

Closed frafra closed 2 years ago

frafra commented 2 years ago

This is a simple CI system, which tries to build a Docker image and push it to GitHub registry.

I am not able to build the image at the moment due to a build error (PR #20 should be merged first). GSS is not a valid name for an image, as it is uppercase, so I had to rename my fork to gss (lowercase). This repository should do the same before merging this PR.

moovida commented 2 years ago

@frafra , you mean that the repo needs to be renamed to "gss" for the action to work?

frafra commented 2 years ago

@frafra , you mean that the repo needs to be renamed to "gss" for the action to work?

It looks like there is a way to make it work, by converting the names to lowercase. There is a GitHub action for that. Some references:

I tested it successfully in my fork: https://github.com/frafra/GSS/pull/2

No need to rename the repository then! :) We just need to merge PR #20 before merging this one. All PR are going to be tested with docker build, and each commit and tag on master is going to have its own Docker image hosted in the project registry, so we can finally have official GSS Docker images with little effort and a bit of CI :)

frafra commented 2 years ago

The image has been build correctly: https://github.com/frafra/GSS/pkgs/container/gss Images are private by default, but such policy can be changed from the web interface (URL, to be adapted: https://github.com/$user/$project/packages/container/gss/settings -> Danger zone).

moovida commented 2 years ago

The link of the page you describe does not exist. And if I look into my settings, in the danger zone I do not see a section about images:

image

frafra commented 2 years ago

I guess it can be set only after something has been published.

moovida commented 2 years ago

ok, let's have a try then.

frafra commented 2 years ago

The image is there, but it should be made visible for everybody.

moovida commented 2 years ago

I am struggeling to find the right spot. Following more or less your url reconstruction I went to:

https://github.com/geopaparazzi/GSS/pkgs/container/gss/settings

which then resolves into:

https://github.com/geopaparazzi/GSS/pkgs/container/gss/17681143

which is visible only when logged.

The only settings I see are the ones of the repo, which is where I do not see anything about visibility of packages.

Any clue?

frafra commented 2 years ago

The URL is wrong, sorry. You should look at https://github.com/geopaparazzi/GSS/pkgs/container/gss and have a "Settings" link on the right bar.

moovida commented 2 years ago

Ahhh, finally found, it is "Package visibility". Didn' see that before. Now I am just struggeling with the fact that I am not allowed to change it. That is really strange, being the admin :-D

moovida commented 2 years ago

Ok, finally, packages are now public :-)

Can you confirm @frafra ?

frafra commented 2 years ago

It works, thank you :-)

moovida commented 2 years ago

Super, thank you :-)