search

geopaparazzi / smash

Source code of the SMASH Android/iOS digital field mapping app.
https://www.geopaparazzi.org/smash/index.html
GNU General Public License v3.0
72 stars 25 forks source link

F-Droid reproducible build failed #270

Closed linsui closed 3 days ago

linsui commented 3 months ago

https://monitor.f-droid.org/builds/log/eu.hydrologis.smash/72#site-footer Was your apk built from the same commit?

moovida commented 3 months ago

Ugh, I was quite sure that I followed the appropriate workflow, but if it failed, there is still something that is wrong. I wonder if there has been some flutter pub get in between that the IDE did and I didn't notice.

What is the best way for solving this? Should I create another tag and rebuild with the current? I assume forcing to move the current tag could cause issues in the fdroid build system, right?

linsui commented 3 months ago

How did you build the apk? Did you apply the same patch? Is there a script? In your apk there are some play services files so I thought your apk didn't patch out play services.

moovida commented 3 months ago

Oh no, that can only be due to the fact that the gps locator lib has changed. :-(

I am using this script, which mimics the same fdroid does: https://github.com/geopaparazzi/smash/blob/master/fdroid_build.sh

linsui commented 3 months ago

Could you use glob for background_locator_2 version in the script?

moovida commented 3 months ago

I am not sure what you mean by that. What is glob?

linsui commented 3 months ago

Our script is cd .pub-cache/git/background_locator*/android and yours is cd .pub-cache/git/background_locator_2-3e0e4dcad802b5122d480c940e391c4b518a4f45/android.

moovida commented 3 months ago

Ugh, I didn't notice that :-( sorry

I also now noticed that there is also the path to the repo, wich is not the same anymore, because it is not developed and we had to create a fixed fork. But this also means I will have to change the build script :-( That will take me a bit more time and I assume that I also will need to create a new release, disabling the 1.9.1.

moovida commented 3 months ago

No, sorry, forget the last one, all seems to be ok now and I am building it with the same lib.

moovida commented 3 months ago

Ok, I updated the script and generated the new old apk. I substituted the old one here on github. Should that work?

linsui commented 3 months ago

It works, thanks!

moovida commented 3 months ago

Thank you @linsui , you guys are always so kind. Sorry for the mess!

licaon-kter commented 2 months ago

so I don't open a new one, your APK https://github.com/geopaparazzi/smash/releases/tag/version_1.9.3%2B74_fdroid started to have an extra -version string added to its name?

this fails for the current F-Droid URL template https://gitlab.com/fdroid/fdroiddata/-/jobs/7202234022 @moovida

moovida commented 2 months ago

This can't be happening. And I even rewrote the script to generate the version name properly. Grrrr

Thanks again @licaon-kter, I have updated the apk. :-(

moovida commented 3 days ago

I think I can finally close this. The last build and release has been successful without human interaction and support