geoparser / geolocator

Apache License 2.0
19 stars 7 forks source link

Files and path coded in hard #5

Open damienpalacio opened 10 years ago

damienpalacio commented 10 years ago

Good morning,

I saw the v2 is on the way. Something nice would be to remove all the path/files hardcoded (like "GazIndex/" "res/") and put it in a configuration file or at least in a Class with static variables. Otherwise if you want to use it with another system everything has to be in the folder you call it.

Have a nice day

geoparser commented 10 years ago

Thanks for the advise, it's not done yet. But Hard coding it in the program is the point, I don't want user to worry about configurating the path, except installing it. I will try to do it soon. The gazetteer structure is greatly changed. If you want to merge it into another system, please wait for a while.

Thanks

Wei

ÔÚ Feb 11, 2014£¬4:58 AM£¬dampalacio notifications@github.com дµÀ£º

Good morning,

I saw the v2 is on the way. Something nice would be to remove all the path/files hardcoded (like "GazIndex/" "res/") and put it in a configuration file or at least in a Class with static variables. Otherwise if you want to use it with another system everything has to be in the folder you call it.

Have a nice day

¡ª Reply to this email directly or view it on GitHub.

jackgucool commented 10 years ago

Hi,

Thanks for you code. Similar to the question above, I can't find the GazIndex that needed to specified in PipelineTest.java. Where can I find this folder?

Thanks