geopavlakos / multishot

Repository for the paper "Human Mesh Recovery from Multiple Shots"
94 stars 7 forks source link

Shouldn't mask_id be a global variable? #2

Open gmindflow opened 2 years ago

gmindflow commented 2 years ago

In the file /optimization/process_phalp.py, In line, 130 there is a variable "mask_id", first appearing in the code. Then, it is used again in line 132.

However, when it is first defined in line 130, it is inside the for loop, which makes it a local variable. So I'm having issues with this.

I inserted "mask_id = 0" in line 61 to define it as a global variable and initialize it. But I'm not completely sure if I did it right. It did proceed on after making the change.

Could you please check over this matter and give me an answer?

Thanks!