search

geophysics / mtpy

collection of python tools for standard MT data processing
GNU General Public License v3.0
32 stars 32 forks source link

Duplicate versions of MTPlotTools.py #5

Open ghost opened 12 years ago

ghost commented 12 years ago

There are two versions of MTPlotTools.py -- one in core and the other in imaging.

One needs to be deleted, but I'm not sure what code is duplicated over both, and whether other modules refer to one or other or both. Jared?

geophysics commented 12 years ago

I'd prefer to have the modules/functions that are generating visual output in a different folder than the purely 'theoretical' ones. Maybe, we can rename 'imaging', if you can come up with something better/more intuitive?

ghost commented 12 years ago

I agree in principle but remember we can do this in a purely cosmetic way, for example with a file at MTpy/plots.py containing:

__all__ = ['plot_something', 'plot_something_else', 'another_plot_function']

from MTpy.core.MTPlotTools import plot_something
from MTpy.imaging.ptplots import plot_something_else
from MTpy.modelling.SomeNewModule import another_plot_function

and then people can:

>>> import MTpy.plots
>>> MTpy.plots.plot_something()
>>> MTpy.plots.plot_something_else()
>>> MTpy.plots.another_plot_function()

After all sometimes plotting code is intimiately related to the processing/modelling/'theoretical' code, and having it so far apart is not the way modules and subpackages should be organized.