search

geopython / GeoHealthCheck

Service Status and QoS Checker for OGC Web Services
https://geohealthcheck.org
MIT License
84 stars 71 forks source link

WFS3 Probe: change name to id for collection identifier #283

Closed justb4 closed 4 years ago

justb4 commented 4 years ago

Problem

Recently and according to specs a Collection within OGC API - Features has an id attribute. Several implementations like pygeoapi were using name. A recent change from name to id in pygeoapi makes the pygeoapi WFS3 Drilldown Probe fail.

Solution

The WFS3 Drilldown Probe needs to change name to id when testing a Collection, like on this line and this line.

pvgenuchten commented 4 years ago

can you set use of "name" as a warning for upcoming months? And at some point in future make it an actual error.

justb4 commented 4 years ago

@pvgenuchten bit hard to realize: each Check renders True or False. And hard to determine when to switch, also with several versions deployed at some point. One can always set Basic (i.s.o. Full mode for the WFS3Drilldown Probe so it won't crawl into all Collections. And pygeoapi is compliant now..

justb4 commented 4 years ago

Fixed via PR #284