Closed fsteggink closed 2 years ago
This issue seems to be related: https://github.com/Yelp/elastalert/issues/2968
The suggested fix (namely to add tzlocal<3.0 as a requirement) works.
The package tzlocal version 3.0 has been released four days ago (Aug. 13th): https://pypi.org/project/tzlocal/. I'll submit a PR for the quick fix, but only for Docker. I don't know if this is needed when GHC is run locally, since I'm only able to run the Docker version on Windows. Perhaps it isn't even needed. It is possible that the Docker time zone is used, and deemed to be incompatible. But for the long term a fix should be made so that tzlocal 3+ works as well.
Ok, yes pytz
is not required currently for non-Docker GHC (unless one runs with gunicorn/eventlet
).
So it comes in as a dependency there, which is always tricky, so often I do pip freeze
and have those deps as requirements.txt, so builds are repeatable without surprises. But the fix in #390 looks ok for now.
Ok #390 fix works, pip freeze
gives:
alabaster==0.7.12
alembic==1.6.5
APScheduler==3.6.1
attrs==21.2.0
Babel==2.9.1
certifi==2021.5.30
charset-normalizer==2.0.4
click==8.0.1
dnspython==1.16.0
docutils==0.16
eventlet==0.30.2
Flask==1.1.1
Flask-Babel==0.12.2
Flask-Login==0.4.1
Flask-Migrate==2.5.2
Flask-Script==2.0.6
Flask-SQLAlchemy==2.4.0
greenlet==1.1.1
gunicorn==20.1.0
idna==3.2
imagesize==1.2.0
importlib-metadata==4.7.1
itsdangerous==1.1.0
Jinja2==3.0.1
jsonschema==3.0.2
lxml==4.6.3
Mako==1.1.5
MarkupSafe==2.0.1
openapi-spec-validator==0.2.8
OWSLib==0.20.0
packaging==21.0
passlib==1.7.1
Paver==1.3.4
psycopg2==2.7.5
Pygments==2.10.0
pyparsing==2.4.7
pyproj==2.6.1.post1
pyrsistent==0.18.0
python-dateutil==2.8.2
python-editor==1.0.4
pytz==2021.1
PyYAML==5.4.1
requests==2.26.0
six==1.16.0
snowballstemmer==2.1.0
Sphinx==4.1.1
sphinx-rtd-theme==0.5.2
sphinxcontrib-applehelp==1.0.2
sphinxcontrib-devhelp==1.0.2
sphinxcontrib-htmlhelp==2.0.0
sphinxcontrib-jsmath==1.0.1
sphinxcontrib-qthelp==1.0.3
sphinxcontrib-serializinghtml==1.1.5
SQLAlchemy==1.3.8
typing-extensions==3.10.0.0
tzlocal==2.1
urllib3==1.26.6
Werkzeug==0.16.1
WTForms==2.2.1
zipp==3.5.0
(nb one needs to activate the /venv/bin/activate
when bashing into the Docker GHC (web) Container)
We need to revisit/freeze all deps: I propose to close this issue and open a new one for "Freeze dependencies". Ok?
@fsteggink think we should add tzlocal<3.0
to requirements.txt for regular installs.
It is used by APScheduler
, see also this issue.
.... I see that fix is also included in recent PR #403 ....So will review/merge that PR first...
Fine with me. I'm not able to test it locally.
With #403 now merged, local install/run works (tzlocal is 2.1) , let's close this.
GHC can't start when freshly built as a Docker container, even when you let GHC initialize a DB. This happens with the current master (#61511405fbeb318caa2133f901b5c43c1266524b)
To reproduce:
For testing purposes I'm running the runner in the web container. This used to work a few weeks ago. The env file doesn't contain anything special. It doesn't matter whether I keep the DB (sqlite) or not.
Output of
docker logs ghc_web
after a few seconds (sqlite db removed, so it gets initialized):GHC version: current master (see above) Docker version: