search

geopython / GeoHealthCheck

Service Status and QoS Checker for OGC Web Services
https://geohealthcheck.org
MIT License
86 stars 69 forks source link

Fix failing unit tests #402

Closed justb4 closed 3 years ago

justb4 commented 3 years ago

Describe the bug Unit tests are failing. looks related to OAFeat OpenAPI Validator Probe. Behaviour is also non-constant (then fails, then success). Also seen on demo site, e.g. https://demo.geohealthcheck.org/resource/346?lang=en

To Reproduce Run the unit tests, see they fail.

Expected Behavior Expected to be all successful.

Screenshots or Logfiles If applicable, add screenshots or logfile texts, to help explain your problem.

FAIL: testRunResoures (test_resources.GeoHealthCheckTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/GeoHealthCheck/GeoHealthCheck/tests/test_resources.py", line 90, in testRunResoures
    (resource.url, str(resource.runs[0])))
AssertionError: False != True : Run should be success for https://demo.ldproxy.net/daraa report=<Run 8>

Context (please complete the following information):

Additional context This issue is long-standing. Sometimes goes away. Looks like related to JSON schema validation and the crawling over OOGC-provided schema resources (?). But maybe also changing OAFeat-standards+OAFeat-implementations mismatches. Needs investigation.

justb4 commented 3 years ago

Leave out the Validator for now. May open new issue to re-add, but the problem is in the implementations (and/or OGC schema resources).

justb4 commented 3 years ago

Ok unit testst green again!