search

geopython / GeoHealthCheck

Service Status and QoS Checker for OGC Web Services
https://geohealthcheck.org
MIT License
84 stars 71 forks source link

OGC 3DTiles Probe for #381 #404

Closed jochemthart1 closed 2 years ago

jochemthart1 commented 2 years ago

This PR adds a probe for OGC 3D Tile services. (#381 )

It requests the tileset.json, retrieves the tile data url from the json and requests the tile data url as well.

Currently, it is written as one probe that checks both the tileset.json and the data url. Another probe could be added if only the tileset.json should be checked.

Both requests are checked for http4/500 errors using the GHC HttpStatusNoError check.

I had to make small changes to models.py and healthcheck.py to make it work differently to other "OGC:" service probes. (similar to OGC:WFS3)

justb4 commented 2 years ago

I had to make small changes to models.py and healthcheck.py to make it work differently to other "OGC:" service probes. (similar to OGC:WFS3)

Yes, that is always the case for new service types!

fsteggink commented 2 years ago

This PR is meant for issue #381

justb4 commented 2 years ago

@jochemthart1 let me know if you are ready for merge, my comments are minor.

jochemthart1 commented 2 years ago

@justb4 This is now ready for merge. I did implement some changes based on your review.

justb4 commented 2 years ago

@jochemthart1 some more patience: see my minor comments above.

justb4 commented 2 years ago

@jochemthart1 almost there, still a flake8 error:

./GeoHealthCheck/plugins/probe/ogc3dtiles.py:11:80: E501 line too long (84 > 79 characters)
Error: Process completed with exit code 1.
justb4 commented 2 years ago

@jochemthart1 ok, here we go, thanks for patience!

justb4 commented 2 years ago

And on demo server: https://demo.geohealthcheck.org/resource/412?lang=en