search

geopython / GeoHealthCheck

Service Status and QoS Checker for OGC Web Services
https://geohealthcheck.org
MIT License
83 stars 71 forks source link

add jspark locally #448

Closed tomkralidis closed 1 year ago

tomkralidis commented 1 year ago

FYI CI failures are unrelated and likely due to Python 3.7 support. @justb4 perhaps we should update to Python 3.8+ (in another PR)?

justb4 commented 1 year ago

CI failures are flake8 deps related it looks like: https://github.com/PyCQA/flake8/issues/1701

You may try

flake8==5.0.4
Paver==1.3.4
pylint==2.13.9

in requirements-dev.txt. Cannot reproduce locally.

justb4 commented 1 year ago

Even in pygeoapi we still use Python 3.7 in CI...

tomkralidis commented 1 year ago

Do we have a 3.7 requirement for GHC?

tomkralidis commented 1 year ago

Looks like a different unrelated CI error.

justb4 commented 1 year ago

Not really but the Docker Image venv also runs Python 3.7.

tomkralidis commented 1 year ago

Suggest we merge this PR and have a future/sprint activity to upgrade to 3.8+?

justb4 commented 1 year ago

But we are much further: CI error is related to changed URL in unit test. I can repare.

justb4 commented 1 year ago

Yes, ok 3.8 in next sprint. Will issue PR to fix unit tests.