first docking prototyp - Githubissues

geopython / MetaSearch

*** We have moved! MetaSearch is now a core QGIS plugin! (2014-11-30). See QGIS repository

https://hub.qgis.org/wiki/quantum-gis/MetaSearch

Other

4 stars 12 forks source link

first docking prototyp #38

Closed rduivenvoorde closed 10 years ago

rduivenvoorde commented 10 years ago

@tomkralidis: with some xml hacking and some code changes, I got the dialog workings as a docking widget.

You can only dock it to the right of the map currently.

Not sure if I find it ok or not... Maybe we should reshuffle bit first, or maybe there is just too much content to show, to make it a dockwidget in one of the borders (would be nice to be able to dock it in centre).

Anyway: plz have a look and let us decide if we want to go like this, or that we should review the full ui first to make it better to put in a dock.

tomkralidis commented 10 years ago

Nice! +1 to move ahead like this. I think to dock as a toolbar would reduce the functionality.

Comments:

needs some code cleanup (we already know that, as this is a poc)
we should bring the help button back somewhere?
the natural / init state is docked. Can it be undocked/popped up? Then the user can dock where they like (of course settings take over from there)
we need to ensure the buttons work again (map extent, set global)

I have the plugin docked below the layer dock and this significantly improves the workflow. Let's push ahead.

kalxas commented 10 years ago

As per the feedback we got from QGIS team, it is preferred to stay to current window style. I suggest that we keep this modification in the source tree history, under a branch for future reference.

tomkralidis commented 10 years ago

OK, we can keep this closed PR as reference, which shows the changes.

rduivenvoorde commented 10 years ago

ok, pushed my branch to this repo:

https://github.com/geopython/MetaSearch/tree/dock

kalxas commented 10 years ago

cool, thanks