[WIP] remove shopt&alias to make it work on powershell

geopython / geopython-workshop

The Doing Geospatial in Python Workshop (mainly provided at FOSS4G events)

https://geopython.github.io/geopython-workshop

Other

55 stars 22 forks source link

[WIP] remove shopt&alias to make it work on powershell #131

Open pvgenuchten opened 1 year ago

pvgenuchten commented 1 year ago

PR to facilitate discussion on this topic

docker-compose was removed >1 year ago, i think we can assume all are migrated by now?

removing shopt and alias because it is not supported on powershell/windows

todo: update docs for windows: syntax: bash geopython-workshop-ctl.sh start|stop|url|update

[x] works on powershell (windows+docker desktop)
[x] works on ubuntu (WSL)

pvgenuchten commented 1 year ago

@tomkralidis, updated docs for powershell

pvgenuchten commented 1 year ago

ah, good to know people are still using docker-compose

alternative would be to duplicate the script and rename to _ps.sh

@justb4 PR updated

justb4 commented 1 year ago

I cannot test this, but seems useful. I wonder if the uname stuff even works. I have no idea how Powershell relates to WSL and Docker install. I have the feeling we would not need a separate Bash script with some smart 'sniffing' like the $Windows var and uname command, branching in the original script. It may be confusing even, two scripts with almost identical names.