search

geopython / geopython-workshop

The Doing Geospatial in Python Workshop (mainly provided at FOSS4G events)
https://geopython.github.io/geopython-workshop
Other
54 stars 22 forks source link

`rasterio` dependency is missing in requirements.txt file #136

Open krishnaglodha opened 1 year ago

krishnaglodha commented 1 year ago

I am trying to run jupyter notebook locally, but in geopython-workshop/workshop/jupyter/requirements.txt rasterio is missing

justb4 commented 1 year ago

I see, but I am hesitant to change geopython-workshop/workshop/jupyter/requirements.txt at this point in time. This file is also used in the Dockerfile and -build where rasterio is installed as a Debian (python3-rasterio) package. There could be potential dependency conflicts, resulting in a failing Notebook. Everything has to be tested again, begin to end. We have a stable situation now. Maybe rasterio was even taken out of requirements.txt for that reason. That file is tuned for the Ubuntu env and .deb installs in the Dockerfile.

At the workshop we will use Docker. Custom install is at own risk. Will need its own requirements.txt , install guide, and base deps like GDAL and Proj. Maybe Conda Forge works better for that case. That would be a useful addition.

krishnaglodha commented 1 year ago

@justb4 got it! Thanks :D

ldesousa commented 1 year ago

I agree it is a bit too late to try this kind of change. The notebook in Section 5 is working fine as it is.

We can give it a try later during the code sprint.