search

geopython / geopython-workshop

The Doing Geospatial in Python Workshop (mainly provided at FOSS4G events)
https://geopython.github.io/geopython-workshop
Other
55 stars 22 forks source link

Added missing data #95

Closed krishnaglodha closed 2 years ago

krishnaglodha commented 2 years ago

2 datasets were missing

  1. countries shape file
  2. stadium.csv both files are added
krishnaglodha commented 2 years ago

fixed following things

  1. added all missing data
  2. checked entire visualisation and vector data file line by line and fixed small bugs
  3. fixed all 3 issues mentioned in PR
  4. fixed issue https://github.com/geopython/geopython-workshop/issues/96
justb4 commented 2 years ago

Also: can you merge with upstream, there seem to be conflicts in Ch4 en Ch7.

krishnaglodha commented 2 years ago

I've merged files @justb4

tomkralidis commented 2 years ago

+1 for keeping the repo size small. We should either provide smaller / thinned out data or specify for download external to the repository.

justb4 commented 2 years ago

Like I said in the Gitter chat, simply download the lowres (110m) versions, order of 120kb, they work as well: https://www.naturalearthdata.com/downloads/110m-cultural-vectors/ Downloading during the workshop won't work in the MyBinder version as there is no local environment.

justb4 commented 2 years ago

So once the smaller versions of the files are in this PR we may merge and then fix the outstanding other problems.

justb4 commented 2 years ago

Also Ch7 from this PR works completely (in Docker version) with the smaller NE files: https://www.naturalearthdata.com/downloads/110m-cultural-vectors/

justb4 commented 2 years ago

Offcourse in Ch4 and Ch7 text change ne_10m_... with ne_110m_...

krishnaglodha commented 2 years ago

I have replaced populated shapefile (70MB) with Geojson ( 18 MB ) and it's references

krishnaglodha commented 2 years ago

Like I said in the Gitter chat, simply download the lowres (110m) versions, order of 120kb, they work as well: https://www.naturalearthdata.com/downloads/110m-cultural-vectors/ Downloading during the workshop won't work in the MyBinder version as there is no local environment.

Sorry, I just saw this. I have made another commit by replacing geojson with this 1.8MB file

justb4 commented 2 years ago

looking again : think all data is already in the repo: countries and populated_places. So the Shapefiles in this PR are not needed. Have little time today going to SOTM,, but the workshop needs to be ready and working. There is also still a 10m Shape 8MB in this PR.

I propose: can you make a new PR with just the Ch4 and Ch7 Notebooks? I merge and fix/add datafiles where needed. Think only the CSVs. All other NE data is already there in various formats. Again no need for the Shapefiles. @tomkralidis