Open vjf opened 6 months ago
Thank you @vjf for this contribution, we will need some time to review. My first comment is: why not add the parsing capability in OWSLib first?
@kalxas Well, amending all the geopython packages to understand ISO 19115-3 XML is quite a large job. It has to be broken up into parts.
There is a demand from the user community for this in pycsw, ckan etc. so I thought this was the best place to start.
I see integrating ISO 19115-3 XML support into OWSLib as the next stage. I haven't looked into how much work this would require.
If you like, I can make a PR for OWSLib and insert the new parser and unit tests. It might need "OWSLib >= XX.XX" in pycsw's requirements file and will require some release coordination timing between OWSLib and pycsw.
Alternatively we can have pycsw use the local copy of the parser now, then once OWSLib has its own parser, pycsw can preferentially load it. We can remove the local parser from pycsw later on.
Great work @vjf! Agree with @kalxas, for maximum reuse and benefit, the MDB parser should be implemented in OWSLib proper (in owslib/iso_3.py
), at which point we can cut an OWSLib release that will be used by pycsw. At that point we can continue the review.
@tomkralidis @kalxas OK, I will migrate mdb.py to OWSLib.
@vjf now that the OWSLib pull request has been merged, can you please make the changes here to align?
@tomkralidis @kalxas
Almost there...
@vjf FYI OWSLib 0.31.0 has now been released.
CI is still failing I see
@kalxas @tomkralidis All fixed. Thanks.
@vjf thank you. We will review and come back with comments
We're planning to upgrade PyCSW for GeoNode and one of the compelling reasons is the support for ISO 19115 Part 3. Did you plan to merge this before the release of PyCSW 3?
@kalxas I take the opportunity to ask if you have a timeline for the release of PyCSW 3.
@kalxas let's review during this week's OGC Sprint.
Overview - Support for ISO 19115 Part 3 XML
This PR contains a new profile for pycsw, called 'iso19115p3'.
Related Issue / Discussion
Additional Information
Contributions and Licensing
(as per https://github.com/geopython/pycsw/blob/master/CONTRIBUTING.rst#contributions-and-licensing)