geopython / pycsw

pycsw is an OGC CSW server implementation written in Python. pycsw fully implements the OpenGIS Catalogue Service Implementation Specification [Catalogue Service for the Web]. Initial development started in 2010 (more formally announced in 2011). The project is certified OGC Compliant, and is an OGC Reference Implementation. pycsw allows for the publishing and discovery of geospatial metadata via numerous APIs (CSW 2/CSW 3, OpenSearch, OAI-PMH, SRU). Existing repositories of geospatial metadata can also be exposed, providing a standards-based metadata and catalogue component of spatial data infrastructures. pycsw is Open Source, released under an MIT license, and runs on all major platforms (Windows, Linux, Mac OS X). Please read the docs at https://pycsw.org/docs for more information.

https://pycsw.org

MIT License

197 stars 153 forks source link

Allow slash in id #960

Closed pvgenuchten closed 4 months ago

pvgenuchten commented 4 months ago

Overview

if id contains a /, a 404 is rendered, by introducing path keyword in blueprint, this is solved (copied from pygeoapi)

Resolves #848

Contributions and Licensing

(as per https://github.com/geopython/pycsw/blob/master/CONTRIBUTING.rst#contributions-and-licensing)

[x] I'd like to contribute [feature X|bugfix Y|docs|something else] to pycsw. I confirm that my contributions to pycsw will be compatible with the pycsw license guidelines at the time of contribution.
[x] I have already previously agreed to the pycsw Contributions and Licensing Guidelines

pvgenuchten commented 4 months ago

Apperently this did not fully solve the case, no plain 404 is rendered anymore, but for some cases a not found exception is displayed

see: https://demo.pycsw.org/gisdata/collections/metadata:main/items/http://capita.wustl.edu/DataspaceMetadata_ISO/CIRA.VIEWS.COf.xml

tomkralidis commented 4 months ago

Weird, this works for me both locally as well as running demo.pycsw.org locally via docker-compose. @kalxas: can we validate the latest image is being pulled on demo.pycsw.org?

pvgenuchten commented 4 months ago

indeed, i think that is the problem, version has not been updated yet

kalxas commented 4 months ago

/opt/demo.pycsw.org$ sudo docker pull geopython/pycsw:latest
latest: Pulling from geopython/pycsw
Digest: sha256:47ef7fab7de761e0798555eb5f872cce75696b0f7fcf474e5a73137d0f17ae4c
Status: Image is up to date for geopython/pycsw:latest
docker.io/geopython/pycsw:latest

kalxas commented 4 months ago

I deleted all the docker images on the demo server and restarted docker compose. @pvgenuchten can you please try again?