8luewater commented 1 month ago

Overview

We found a few opportunities to increase convenience with clients who use datasets from Oracle databases in pygeoapi. The changes in this PR are tested with large Oracle datasets that Geoscience Australia (https://www.ga.gov.au/) manages on behalf of public stakeholders.

Related Issue / discussion

1. Oracle provider did not stand up: With the latest master, pygeoapi did not start correctly when Oracle layers were included in the config yml file. To fix this, we added oracledb in the requirements.txt and this resolved the issue. - removed this change as requested by reviewers.

Pagination did not show up on Oracle Items page: Items page for Oracle layers did not show up. numbersMatched value to be returned in query function. The changes in oracle.py fixed this issue.

Additional information

I believe that the changes are very much relevant for anyone using Oracle layers in pygeoapi.

Dependency policy (RFC2)

[x] I have ensured that this PR meets RFC2 requirements

Updates to public demo

[x] I have ensured that breaking changes to the pygeoapi master demo server have been addressed
- [x] https://github.com/geopython/demo.pygeoapi.io/blob/master/services/pygeoapi_master/local.config.yml

Contributions and licensing

(as per https://github.com/geopython/pygeoapi/blob/master/CONTRIBUTING.md#contributions-and-licensing)

[x] I'd like to contribute [feature X|bugfix Y|docs|something else] to pygeoapi. I confirm that my contributions to pygeoapi will be compatible with the pygeoapi license guidelines at the time of contribution
[x] I have already previously agreed to the pygeoapi Contributions and Licensing Guidelines

Appreciation

Thank you very much for your time and consideration about my pull request. Working with pygeoapi is one of my happiest times.

tomkralidis commented 1 month ago

cc @totycro

8luewater commented 1 month ago

Thank you for your another comment. Unpinned.