geopython / pywps

PyWPS is an implementation of the Web Processing Service standard from the Open Geospatial Consortium. PyWPS is written in Python.
https://pywps.org
MIT License
178 stars 117 forks source link

using io.open #483

Closed cehbrecht closed 5 years ago

cehbrecht commented 5 years ago

Overview

This PR is updating PR #475 and uses io.open.

Related Issue / Discussion

475

Additional Information

https://stackoverflow.com/questions/40809901/python-2-7-io-open-use-from-io-import-open-or-io-open#40809945

Contribution Agreement

(as per https://github.com/geopython/pywps/blob/master/CONTRIBUTING.rst#contributions-and-licensing)

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 74.05% when pulling d5939ca3ccb52981baa52554c4a09c55ad2ff05b on cehbrecht:update-pr-475-io-open into 5c52cd945a7a971e81ceee9a0ceb1d02b476fa5e on geopython:master.

cehbrecht commented 5 years ago

Looks like this approach leads into more PY2 compatibility troubles:

File "pywps/inout/basic.py", line 387, in file

    fh.write(self.data)

TypeError: write() argument 1 must be unicode, not str
cehbrecht commented 5 years ago

skipping this PR ... it becomes obsolete when using Python 3 only.