geopython / pywps

PyWPS is an implementation of the Web Processing Service standard from the Open Geospatial Consortium. PyWPS is written in Python.
https://pywps.org
MIT License
178 stars 117 forks source link

Fix urlparse usage #487

Closed corrado9999 closed 5 years ago

corrado9999 commented 5 years ago

Overview

Fix pywps._compat.urlparse usage. pywps._compat.urlparse is a function, but pywps.inout.literaltypes.convert_anyURI used it as a module.

Related Issue / Discussion

486

Additional Information

When adding the test function, another issue emerged with file:/// schema, thus we agreed to handle this case separately (see #486).

Contribution Agreement

(as per https://github.com/geopython/pywps/blob/master/CONTRIBUTING.rst#contributions-and-licensing)

corrado9999 commented 5 years ago

In my local installation I can successfully run the tests on Python 3 (I copied and pasted the commands from the CI log), any help on why the CI reports failure? On Python 2.7 I get errors too, but they are related to unicode encoding, not my edits (I get them also on the master branch/rep).

cehbrecht commented 5 years ago

@corrado9999 there was an update on master with the imports. Please merge master in this PR. Check the imports: https://github.com/geopython/pywps/blob/b7ef2dd6b955a32b698cbe3befebf90c49d379b5/tests/test_literaltypes.py#L10

... and you need to add convert_anyURI and InvalidParameterValue.

I got also confused by the tests :)

coveralls commented 5 years ago

Coverage Status

Coverage increased (+1.3%) to 75.443% when pulling 692b053bb47d25e5dffb406d743290ec44a038e4 on corrado9999:fix-urlparse-usage into b7ef2dd6b955a32b698cbe3befebf90c49d379b5 on geopython:master.

cehbrecht commented 5 years ago

@corrado9999 merged. Thanks :)