geopython / pywps

PyWPS is an implementation of the Web Processing Service standard from the Open Geospatial Consortium. PyWPS is written in Python.

https://pywps.org

MIT License

178 stars 117 forks source link

fix file storage #504

Closed cehbrecht closed 4 years ago

cehbrecht commented 4 years ago

Overview

This PR fixes the file storage. Output files were not saved to storage after introducing PR #451.

Related Issue / Discussion

451 Additional Information

Contribution Agreement

(as per https://github.com/geopython/pywps/blob/master/CONTRIBUTING.rst#contributions-and-licensing)

[x] I'd like to contribute [feature X|bugfix Y|docs|something else] to PyWPS. I confirm that my contributions to PyWPS will be compatible with the PyWPS license guidelines at the time of contribution.
[x] I have already previously agreed to the PyWPS Contributions and Licensing Guidelines

cehbrecht commented 4 years ago

@roarmstrong @davidcaron @huard Please have a look it this PR. File storage currently does not work on master ... didn't notice before. I was using the latest release of pywps in emu.

davidcaron commented 4 years ago

I ran into the same issue a couple hours ago 🙂 I came into the same conclusion as you did, I think this will fix it.

huard commented 4 years ago

Not familiar with this part of the code.

roarmstrong commented 4 years ago

Fix looks good to me, apologies I didn't catch this in the original PR!

jachym commented 4 years ago

if I reed this correctly, travis is complaining about the code style?

otherwise it can be merged IMHO, thank you

coveralls commented 4 years ago

Coverage increased (+0.03%) to 75.161% when pulling fa519ec130eaba9da3e6e48fedd523e3180befaa on cehbrecht:fix-file-storage into a0ff367eeda7eeee6a6b7c80d048019bd81445b8 on geopython:master.

cehbrecht commented 4 years ago

@davidcaron @huard @roarmstrong @jachym merged. Thanks for your quick response and review :)