geopython / pywps

PyWPS is an implementation of the Web Processing Service standard from the Open Geospatial Consortium. PyWPS is written in Python.
https://pywps.org
MIT License
177 stars 117 forks source link

fix bbox in execute template #552

Closed cehbrecht closed 3 years ago

cehbrecht commented 3 years ago

Overview

According to the wps 1.0.0 schema the bbox in the execute response should look like this:

<wps:BoundingBoxData crs="epsg:4326" dimensions="2">
          <ows:LowerCorner> -90.0 -180.0</ows:LowerCorner>
           <ows:UpperCorner> 90.0 180.0</ows:UpperCorner>
</wps:BoundingBoxData>

The schema has no entry for WGS84BoundingBox.

Related Issue / Discussion

Additional Information

Contribution Agreement

(as per https://github.com/geopython/pywps/blob/master/CONTRIBUTING.rst#contributions-and-licensing)

cehbrecht commented 3 years ago

WPS Execute outputs are:

<element name="Output" type="wps:OutputDataType" maxOccurs="unbounded">

https://github.com/opengeospatial/ets-wps10/blob/884f69b9bef900f832bd3ffaead5e99aab972032/src/main/resources/xsd/ogc/wps/1.0.0/wpsExecute_response.xsd#L58

These can be Data:

<element name="Data" type="wps:DataType">

And this can be a bbox:

<element name="BoundingBoxData" type="ows:BoundingBoxType">

https://github.com/opengeospatial/ets-wps10/blob/884f69b9bef900f832bd3ffaead5e99aab972032/src/main/resources/xsd/ogc/wps/1.0.0/wpsExecute_request.xsd#L240

ows:BoundingBoxType with lower and upper corner: https://github.com/opengeospatial/ets-wps10/blob/884f69b9bef900f832bd3ffaead5e99aab972032/src/main/resources/xsd/ogc/ows/1.1.0/owsCommon.xsd#L67

coveralls commented 3 years ago

Coverage Status

Coverage remained the same at 75.442% when pulling 13e540f84dc3cf75304c8172985e62269c899512 on cehbrecht:fix-bbox-response into 83c3680ebff89a18f4ebb82d4d4520516d7c5013 on geopython:pywps-4.2.