geopython / pywps

PyWPS is an implementation of the Web Processing Service standard from the Open Geospatial Consortium. PyWPS is written in Python.
https://pywps.org
MIT License
178 stars 117 forks source link

move MetadataUrl to pywps.app.Common to avoid dependencies on sphinx #565

Closed tlvu closed 3 years ago

tlvu commented 3 years ago

Fixes https://github.com/geopython/pywps/issues/564

Tried the same steps as in the original issues, the error is gone.

$ python                                                                                                                                        
Python 3.8.5 (default, Sep  4 2020, 07:30:14)                                                                                                         
[GCC 7.3.0] :: Anaconda, Inc. on linux                                                                                                                
Type "help", "copyright", "credits" or "license" for more information.                                                                                
>>> from pywps import tests                                                                                                                           
>>>              

Also tested this change in project using MetadataUrl at the old location:

cd <flyingpigeon checkout>
conda env update -f environment-docs.yml
conda activate flyingpigeon-docs
pip install git+https://github.com/geopython/pywps@fix-pywps.ext_autodoc.MetadataUrl-wrong-location --upgrade
make docs

Contribution Agreement

(as per https://github.com/geopython/pywps/blob/master/CONTRIBUTING.rst#contributions-and-licensing)

coveralls commented 3 years ago

Coverage Status

Coverage decreased (-0.5%) to 74.957% when pulling d389ee637044b09eb1c91f9a5d21dceebf71e520 on fix-pywps.ext_autodoc.MetadataUrl-wrong-location into effc9cd3195814a5b4ff541c98704947d467fcd0 on pywps-4.2.

cehbrecht commented 3 years ago

Looks good. @cehbrecht Is it ok to push this in the 4.2 branch? I'm still confused regarding the status of master.

Yes ... the 4.2 branch is still our production version.

cehbrecht commented 3 years ago

@tlvu @huard Thanks for the fix :smile: