geopython / pywps

PyWPS is an implementation of the Web Processing Service standard from the Open Geospatial Consortium. PyWPS is written in Python.
https://pywps.org
MIT License
178 stars 117 forks source link

fixed file size check for outputs #580

Closed cehbrecht closed 3 years ago

cehbrecht commented 3 years ago

Overview

This PR fixes the file size check for outputs.

The creation of an output with metalink failed when the output file exceeded the maxsingleinputsize value.

The root cause for this error is fixed in the PR #581.

Related Issue / Discussion

Fix #571

Additional Information

Contribution Agreement

(as per https://github.com/geopython/pywps/blob/master/CONTRIBUTING.rst#contributions-and-licensing)

cehbrecht commented 3 years ago

tests have troubles with gdal installation ...

coveralls commented 3 years ago

Coverage Status

Coverage remained the same at 0.0% when pulling 49c3d37988127cd50a6ee76f14e74ed1bf654715 on cehbrecht:fix-filesizeexceeded into bbca1e42b63cf9c31c40fa3e2a731a1528adb2b9 on geopython:pywps-4.4.

cehbrecht commented 3 years ago

Test CI was using ubuntu-latest with is now using gdal=3. As workaround I'm using ubuntu-18.04.

I open an issue for gdal to solve separately ... well, already there #398.

cehbrecht commented 3 years ago

The cause for FileSizeExceeded was probably an unwanted download when using metalink with URL items. So I can remove the new parameter maxsingleoutputsize ... is is not necessary. See #581.

cehbrecht commented 3 years ago

@huard @Zeitsperre merged. Need a patch release on monday. Please complain ... we can fix it with another patch release :)