geopython / pywps

PyWPS is an implementation of the Web Processing Service standard from the Open Geospatial Consortium. PyWPS is written in Python.

https://pywps.org

MIT License

177 stars 117 forks source link

Make PyWPS Windows friendly #594

Closed idanmiara closed 3 years ago

idanmiara commented 3 years ago

Overview

Resolved all the issues that prevented the tests to pass on Windows.

Contribution Agreement

(as per https://github.com/geopython/pywps/blob/master/CONTRIBUTING.rst#contributions-and-licensing)

[X] I'd like to contribute [feature X|bugfix Y|docs|something else] to PyWPS. I confirm that my contributions to PyWPS will be compatible with the PyWPS license guidelines at the time of contribution.
[X] I have already previously agreed to the PyWPS Contributions and Licensing Guidelines

idanmiara commented 3 years ago

Not sure why 3.6 failed and 3.7 got canceled...

idanmiara commented 3 years ago

@cehbrecht Could you review please?

idanmiara commented 3 years ago

Barring a few changes, looks good. I leave @cehbrecht to do the approval.

Thanks for your review!

Zeitsperre commented 3 years ago

PyWPS seems to be failing for Python3.6. Looking into this now.

idanmiara commented 3 years ago

Finally it's ready!

coveralls commented 3 years ago

Coverage remained the same at 0.0% when pulling 1577cfa33b91ced219573a71e1e980bf3e1eabc9 on talos-gis:pywps-4.4-win into b9fca6e75fd3d9d0d5fcc074d858297c2d104813 on geopython:pywps-4.4.

cehbrecht commented 3 years ago

I'm confused by the diff ... why is tests/processes/metalinkprocess.py shown as deleted and then added?

Zeitsperre commented 3 years ago

Oh! It's because the example process was originally in the docs and then was referred to within the processes. How strange! Good catch. This is a much better approach.

idanmiara commented 3 years ago

I'm confused by the diff ... why is tests/processes/metalinkprocess.py shown as deleted and then added?

As @Zeitsperre wrote, there was a symlink between the file at the docs to the source dir. Symlinks are not compatible with Windows, so I've moved the file to the source dir and referenced it from the docs instead of a symlink. I've tried to do it in one commit but git does not change the status of the file from symlink to regular file, so I ended up removing the symlink and then moving the file and update the rst reference

cehbrecht commented 3 years ago

@idanmiara @Zeitsperre I might use pywps.util instead of pywps.uri ... I leave the vote to you :) I will merge then.

idanmiara commented 3 years ago

@idanmiara @Zeitsperre I might use pywps.util instead of pywps.uri

done. Is the CI broken now ?

Zeitsperre commented 3 years ago

@idanmiara It is but not because of you. The fix is quite simple if you want to add it. In .github/workflows/main.yml:

sudo apt-get -y install gdal-bin libgdal-dev libnetcdf-dev libhdf5-dev

Should be changed to:

sudo apt-get update && sudo apt-get -y install gdal-bin libgdal-dev libnetcdf-dev libhdf5-dev

I don't think either of us has access to the GithHub action. @cehbrecht ?

cehbrecht commented 3 years ago

@idanmiara It is but not because of you. The fix is quite simple if you want to add it. In .github/workflows/main.yml:
sudo apt-get -y install gdal-bin libgdal-dev libnetcdf-dev libhdf5-dev
Should be changed to:
sudo apt-get update && sudo apt-get -y install gdal-bin libgdal-dev libnetcdf-dev libhdf5-dev
I don't think either of us has access to the GithHub action. @cehbrecht ?

you can update it in this PR changing the workflow: https://github.com/geopython/pywps/blob/pywps-4.4/.github/workflows/main.yml

Zeitsperre commented 3 years ago

@idanmiara It is but not because of you. The fix is quite simple if you want to add it. In .github/workflows/main.yml:
sudo apt-get -y install gdal-bin libgdal-dev libnetcdf-dev libhdf5-dev
Should be changed to:
sudo apt-get update && sudo apt-get -y install gdal-bin libgdal-dev libnetcdf-dev libhdf5-dev
I don't think either of us has access to the GithHub action. @cehbrecht ?
you can update it in this PR changing the workflow: https://github.com/geopython/pywps/blob/pywps-4.4/.github/workflows/main.yml

Of course! I was looking at the master and got very confused as to why I couldn't find it. I forget that we don't base directly off master for this project.

idanmiara commented 3 years ago

@idanmiara It is but not because of you. The fix is quite simple if you want to add it. In .github/workflows/main.yml:
sudo apt-get -y install gdal-bin libgdal-dev libnetcdf-dev libhdf5-dev
Should be changed to:
sudo apt-get update && sudo apt-get -y install gdal-bin libgdal-dev libnetcdf-dev libhdf5-dev
I don't think either of us has access to the GithHub action. @cehbrecht ?
you can update it in this PR changing the workflow: https://github.com/geopython/pywps/blob/pywps-4.4/.github/workflows/main.yml
Of course! I was looking at the master and got very confused as to why I couldn't find it. I forget that we don't base directly off master for this project.

done, now it works :)