[x] I'd like to contribute [feature X|bugfix Y|docs|something else] to PyWPS. I confirm that my contributions to PyWPS will be compatible with the PyWPS license guidelines at the time of contribution.
[x] I have already previously agreed to the PyWPS Contributions and Licensing Guidelines
Coverage remained the same at 0.0% when pulling 9e9dc236a96c986312b1987b4c94fa0c3bafbe79 on fmigneault:fix-mimetype-none into 16355299bc3147dd8215d0d13b78c49b4380c50e on geopython:pywps-4.4.
Related Issue / Discussion
When parsing the XML of the WPS execute request (in
parse_post_execute
): https://github.com/geopython/pywps/blob/88d2d4d5d0b4c1d1c39b0eaacf3e22d0b835d01b/pywps/app/WPSRequest.py#L280 The outputs that do not provide amimetype
explicitly are defaulted toNone
: https://github.com/geopython/pywps/blob/88d2d4d5d0b4c1d1c39b0eaacf3e22d0b835d01b/pywps/app/WPSRequest.py#L590When those output definitions eventually reach the following call, the field
mimetype
exists and isNone
, making both themimetype != ''
compare and'MimeType ' + mimetype + ' not valid'
fail (raises cannot concatenate non-string). https://github.com/geopython/pywps/blob/cd71ee76c0f425e1267c842713bb634f800e7e2a/pywps/app/Process.py#L453-L479This PR simply sets it to the default
''
Additional Information
Contribution Agreement
(as per https://github.com/geopython/pywps/blob/master/CONTRIBUTING.rst#contributions-and-licensing)